[Feature] Products filtering by channel #11442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
May 11, 2020
SirDomin
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
CoderMaggie
added
Behat
lchrusciel
previously approved these changes
May 11, 2020
pamil
reviewed
May 11, 2020
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
SirDomin
changed the title
lchrusciel
reviewed
May 12, 2020
src/Sylius/Bundle/AdminBundle/Resources/config/grids/product.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/grids/product.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Doctrine/ORM/ProductRepository.php
Outdated
Show resolved
Hide resolved
lchrusciel
approved these changes
May 12, 2020
| use Sylius\Component\Grid\Data\DataSourceInterface; | ||
| use Sylius\Component\Grid\Filtering\FilterInterface; | ||
|
|
||
| final class EntitiesFilter implements FilterInterface |
There was a problem hiding this comment.
Should we consider moving this class to GridBundle? Also, perhaps for training purposes, we could add spec for this class as well.
There was a problem hiding this comment.
Anyway, I'd merge this as it is now and extract it next.
GSadee
reviewed
May 13, 2020
features/product/managing_products/filtering_products_by_channel.feature
Outdated
Show resolved
Hide resolved
pamil
approved these changes
May 13, 2020
Tomanhez
reviewed
May 13, 2020
Comment on lines
+16
to
+18
| /** | ||
| * {@inheritdoc} | ||
| */ |
There was a problem hiding this comment.
Kinda, but I guess we should remove them once and for all soon.
lchrusciel
approved these changes
May 13, 2020
Zales0123
approved these changes
May 13, 2020
|
Thank you, @SirDomin! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.